Skip to content

Wipe anyway if the sketch name has changed #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Wipe anyway if the sketch name has changed #135

wants to merge 1 commit into from

Conversation

facchinm
Copy link
Member

solves arduino/Arduino#4862

If build.path is hardcoded in preferences.txt the current routine doesn't wipe the build directory, so we end up with a couple of .o defining setup() and loop().
If we switch sketch, wipe anyway (note that, by default, every IDE window defines its own build.path so we don't wipe unless the target board has changed)

@facchinm facchinm force-pushed the wipe_on_different_sketch_same_build_path branch from f58b359 to 11e3e8d Compare May 2, 2016 15:55
@matthijskooijman
Copy link
Collaborator

@facchinm, I'm working on some changes to support better debugging symbols, which indirectly also fix this bug (by implementing part of #86). I should have a PR somewhere this week, so you might want to hold off on merging this PR for a bit more.

@facchinm facchinm force-pushed the wipe_on_different_sketch_same_build_path branch from 11e3e8d to 297cbb5 Compare May 3, 2016 16:16
@facchinm facchinm force-pushed the wipe_on_different_sketch_same_build_path branch from 297cbb5 to c2b951c Compare May 3, 2016 16:19
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-135.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@cmaglie cmaglie mentioned this pull request May 6, 2016
Merged
@facchinm
Copy link
Member Author

facchinm commented May 6, 2016

Superseded by #144

@facchinm facchinm closed this May 6, 2016
@cmaglie
Copy link
Member

cmaglie commented May 6, 2016

There is a problem in the loop logic: if the sketch has the same name the other build options are ignored.

@matthijskooijman I've made #144 that fixes this and another problem. Since the current hourly builds are affected I'm going to merge #144 quickly and release upstream.

@cmaglie cmaglie modified the milestone: 1.3.18 May 23, 2016
@cmaglie cmaglie deleted the wipe_on_different_sketch_same_build_path branch January 11, 2018 10:41
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
1.3.18
Development

Successfully merging this pull request may close these issues.
5 participants
@facchinm @matthijskooijman @ArduinoBot @cmaglie @per1234